Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Firebase class to use a factory constructor and makes the adminApp and firestoreAdmin properties non-nullable and required. This change necessitates updates to the authentication and App Check token extraction functions, which now require a FirebaseApp instance as a parameter. Feedback suggests improving the unit tests by using a mock FirebaseApp instead of initializing a real Firebase instance to ensure better test isolation and avoid potential side effects from the Admin SDK.
kevmoo
force-pushed
the
cleanup
branch
2 times, most recently
from
7d546c8 to
c98e127
Compare
- Replace `skipTokenVerification` flag in token checking with `adminApp` presence check - Use `firebase.$env` for accessing environment details - Consolidate token extraction tests to reflect simplified API - Resolve trace context testing issues
Lyokone
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try...catchwrapper aroundFirebaseApp.initializeApp()to fail hard on initialization errors rather than suppressing them.extractAuthToken,extractAppCheckToken) to allow a nullableauthorappCheckinstead replacing the theskipbit.https_auth_test.dartto be a lot more simple.